fix: define missing _create_error_chat_response helper#53
Open
Doondi-Ashlesh wants to merge 1 commit intoNVIDIA-AI-Blueprints:mainfrom
Open
fix: define missing _create_error_chat_response helper#53Doondi-Ashlesh wants to merge 1 commit intoNVIDIA-AI-Blueprints:mainfrom
Doondi-Ashlesh wants to merge 1 commit intoNVIDIA-AI-Blueprints:mainfrom
Conversation
_create_error_chat_response was called in four error-handling paths (timeout, connection, validation, and general exceptions) but was never defined, causing a NameError crash on every error path. Add the missing function returning a ChatResponse with route='error' and the error details in structured_data. Fixes NVIDIA-AI-Blueprints#30 Signed-off-by: Doondi-Ashlesh <doondiashlesh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_create_error_chat_responsewas called in four error-handling paths (timeout, connection, validation, and general exceptions) insrc/api/routers/chat.pybut was never defined, causing aNameErrorcrash on every error path.Fix
Add the missing function returning a
ChatResponsewithroute="error"and the error details instructured_data.Test plan
NameErroris raisedFixes #30